Skip to content

feat/3376 fix/2955 image alt #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Arukuen wants to merge 2 commits into from
Closed

feat/3376 fix/2955 image alt #3377

Arukuen wants to merge 2 commits into from

Conversation

@Arukuen
Copy link
Contributor

@Arukuen Arukuen commented Dec 3, 2024

fixes #2955
fixes #3376

The fix for #2955 also considers the expected behavior from the previous issue #2524. That is:

  • If uploaded media library image has existing alt text, should overwrite custom alt text
  • If uploaded media library image has no alt text (empty or blank), should NOT overwrite custom alt text

For #3376, we should allow explicit empty string for alt since the Image Alt Text Box: image links the W3 Alt standard (similar to native Image) which says empty string for alt (decorative) has different interpretation compared to undefined alt.

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

🤖 Pull request artifacts

file commit
pr3377-stackable-3377-merge.zip a67e1f5

github-actions bot added a commit that referenced this pull request Dec 3, 2024
@github-actions
Upload pr3377-stackable-3377-merge.zip (a67e1)
984f61b 
Pull request: #3377
Commit: a67e1f5
@github-actions
Copy link

github-actions bot commented Dec 3, 2024

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3377-stackable-3377-merge.zip"}}]}

@bfintal
Copy link
Contributor

bfintal commented Jan 31, 2025

Closed in favor of #3404 - added option to show empty alt tag

@bfintal bfintal closed this Jan 31, 2025
@bfintal bfintal deleted the feat/3376-fix/2955-image-alt branch January 31, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@Arukuen @bfintal